Closed
Conversation
04d4d7f to
5fe6e82
Compare
ecc21e3 to
b498fab
Compare
iluuu1994
reviewed
Aug 19, 2024
Member
iluuu1994
left a comment
There was a problem hiding this comment.
I have not managed to finish the review today, I'll continue tomorrow.
iluuu1994
reviewed
Aug 20, 2024
iluuu1994
reviewed
Aug 20, 2024
39f625b to
3b3a200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/lazy-objects
php-src/Zend/zend_lazy_objects.c
Lines 19 to 36 in fb0ced9
The implementation is quite simple:
ReflectionClass::newInstanceWithoutConstructor(), followed byunset()on all properties.__getor trigger warnings). When accessing an undefined property for an object marked lazy, we call the initializer function, and restart the operation.The engine doesn't need to be aware of lazy objects at all: everything is handled in standard object handlers.
zend_lazy_objects.cimplements the logic of making an object lazy, or initializing a lazy object. Functions in these files are called by eitherzend_object_handlers.c, orext/reflection/php_reflection.c.