Fix #70417: PharData::compress() doesn't close temp file #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted formatting according to requirements Test case for bug #73087
* PHP-5.6: add missing RETURN_STRINGL_CHECK
FTS3 is already enabled by default, and the other FTS versions seems just to have been missed. Given that, the other FTS plugins look like a low impact so worth a try. The current bundled libsqlite versions in 7.x are proven stable already and support FTS5.
* PHP-5.6: Fixed bug #73418 Integer Overflow in "_php_imap_mail" leads to crash Fix #72696: imagefilltoborder stackoverflow on truecolor images Fix #72482: Ilegal write/read access caused by gdImageAALine overflow Fix bug #73144 and bug #73341 - remove extra dtor Fix bug #73331 - do not try to serialize/unserialize objects wddx can not handle
* phpsec/PHP-7.0.13: Fixed bug #73418 Integer Overflow in "_php_imap_mail" leads to crash Fix #72696: imagefilltoborder stackoverflow on truecolor images Fix #72482: Ilegal write/read access caused by gdImageAALine overflow Fix bug #73144 and bug #73341 - remove extra dtor remove unreferenced var came in with merge Fix bug #73331 - do not try to serialize/unserialize objects wddx can not handle fix version set versions
* PHP-5.6: fix memory leak
* PHP-5.6: add missing NEWS entry
Fix int overflows in conversation functions for calendar. Add tests for the overflows.
* PHP-7.0.15: Fix #73832 - leave the table in a safe state if the size is too big. Fix bug #73831 - NULL Pointer Dereference while unserialize php object
* pull-request/1905: pack()/unpack() for Big Endian float/double and Little Endian float/double
Persistent connections skipped resetting $connect_error and $connect_errno values This adds the "clear error" line to persistent connections for consistency
some more could be added
* pull-request/1312: get_defined_functions extra parameter to exclude disabled functions news entry for PR php#1312
* pull-request/2273: Update copyright headers to 2017
Member
|
@cmb69 this looks okay to me, although I'm not super familiar with phar ... Please can you rebase this on a 7 branch (I think 7.0 if @weltling does not object) ... if no objections are forthcoming in the following days, it can be merged by yourself, I consider it a bug fix ... leaving files open is obviously nasty. |
* pull-request/1256: Fix php-fpm.service.in
According to the comment, it has not been deemed necessary to close compressed files. However, we don't want to keep unclosed file handles to save ressources. So we're also closing compressed archives, if they're not aliased.
Member
Author
|
Oops, the rebase & force-push didn't work as intended. Sorry! I'm closing this PR, and going to open another one for PHP-7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment, it has not been deemed necessary to close compressed
files. However, we don't want to keep unclosed file handles to save ressources.
So we're also closing compressed archives, if they're not aliased.
I'm not 100% sure if the patch is correct, so it would be good if someone could carefully review it.