Merged
Conversation
This test fails over and over again every time we update the library or because of small changes elsewhere. This leads to a cycle of test failures and us bumping the values again. This test has little value so I propose to just get rid of it. Fixes phpGH-13795.
Member
|
I'm generally somewhat concerned about dropping bug fix tests, due to https://bugs.php.net/bug.php?id=36365#1571126095 (I had not added a test originally because it's slow, but the bug got re-introduced, and wasn't found in time, so a couple of minor PHP versions had the bug). However, in this case it appears to be about an upstream bug for which the fix had been back-ported quite a while ago, so regression testing should be done upstream. Thus, I'm fine with dropping the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails over and over again every time we update the library or because of small changes elsewhere. This leads to a cycle of test failures and us bumping the values again. This test has little value so I propose to just get rid of it.
Fixes GH-13795.