Skip to content

Fix zend_fetch_debug_backtrace() when EG(current_execute_data) == NULL. #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LawnGnome wants to merge 1 commit into from
Closed

Fix zend_fetch_debug_backtrace() when EG(current_execute_data) == NULL. #1482

LawnGnome wants to merge 1 commit into from

Conversation

@LawnGnome
Copy link
Contributor

@LawnGnome LawnGnome commented Aug 22, 2015

This is a regression from PHP 5, which never attempted to dereference fields in the execute data without first checking if it was NULL.

Fix zend_fetch_debug_backtrace() when EG(current_execute_data) == NULL.
1fa607c 
This is a regression from PHP 5, which never attempted to dereference fields in
the execute data without first checking if it was NULL.
@laruence
Copy link
Member

laruence commented Aug 22, 2015

is there a way to trigger the null pointer dereference? I mean a phpt :)

@LawnGnome
Copy link
Contributor Author

LawnGnome commented Aug 22, 2015

@laruence I wasn't able to come up with one easily — this was something I hit while working on an extension, rather than in PHP code. If you have any ideas, I'm happy to experiment!

@laruence
Copy link
Member

laruence commented Aug 23, 2015

Just for the record, this is what I commented on bugs.php.net:

Not sure about that, if there is no active_execute_data, then it must not be in execution..
then maybe this fucntion should not be called at all

however, add a protection in such a not-common used function, seems is also okey. :)

@smalyshev smalyshev added the Bug label Sep 28, 2015
@laruence
Copy link
Member

laruence commented Nov 9, 2015

A fix has been committed in d70aa14 thanks :)

@laruence laruence closed this Nov 9, 2015
@buixor buixor mentioned this pull request Jan 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LawnGnome @laruence @smalyshev