Skip to content

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Jun 4, 2015

The fix is pretty much obvious; for details see bug #69551.

@laruence laruence added the Bug label Jun 5, 2015
@weltling
Copy link
Contributor

weltling commented Jun 8, 2015

@cmb69, just checked and your fix seems to be applicable to 5.5 at least. Could you please check that (maybe rebasing this one or creating another PR for the PHP5 tree)?

Thanks.

@cmb69
Copy link
Member Author

cmb69 commented Jun 9, 2015

@weltling I have created another PR (#1336) based on the PHP-5.5 branch (the PHP-5 branch doesn't seem to be used anymore). I have done so by cherry-picking the 3 commits from the cmb69:parse-ini branch into a current PHP-5.5 branch without having any conflicts.

@php-pulls
Copy link

Comment on behalf of ab at php.net:

merged, thanks! This has to be a lucky case then without conflicts, as the most of the parsers differ massively :)

@php-pulls php-pulls closed this Jun 10, 2015
@cmb69 cmb69 deleted the parse-ini branch July 12, 2015 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants