Skip to content

Optimize strcspn #12594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Girgias merged 2 commits into from
Nov 4, 2023
Merged

Optimize strcspn #12594

Girgias merged 2 commits into from
Nov 4, 2023

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Nov 2, 2023 •
edited
Loading

Also fixes #12592
Marking as a draft because:

  • Waiting for feedback on the issue to know if we can fix the bug or not.
  • I need to check if deferring to a common method has any performance influence.

@ndossche ndossche marked this pull request as ready for review November 2, 2023 19:45
@ndossche ndossche requested a review from bukka as a code owner November 2, 2023 19:45
@ndossche ndossche requested a review from Girgias November 2, 2023 19:45
@Girgias Girgias merged commit 9a973a3 into php:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

strcspn() odd behaviour with NUL bytes and empty mask

2 participants

@ndossche @Girgias