Fixed bug #69336 (Parsing error of strtotime) #1207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@derickr ping |
ext/date/lib/tm2unixtime.c
Outdated
Contributor
There was a problem hiding this comment.
indent seems to be a bit off
Contributor
Author
There was a problem hiding this comment.
I will fix this, thanks.
2e21bde to
eabac9d
Compare
Member
|
I've fixed it in a slightly more comprehensive way by using constants instead of hard coded 1 and 2 values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this problem from: https://twitter.com/laruence/status/582766663705083904
This problem can be reproduced if the day num we are parsing is smaller than today's num.
Example:
Today is 31/03/2015, we want get the last day of April
Today is 29/05/2015, we want get the last day of Feb.