Skip to content

Conversation

@reeze
Copy link
Contributor

@reeze reeze commented Mar 3, 2015

This was uncovered by master's new tests: Zend/tests/assert/expect_015.php

And fix the valgrind warning: https://gist.github.com/mbeccati/d4109974c5a82cf495a8

reeze added 3 commits March 4, 2015 02:20
This was uncovered by master's new tests: Zend/tests/assert/expect_015.php
@laruence
Copy link
Member

laruence commented Mar 5, 2015

After reviewing, unfortunately, your fix is not fully correct and not well, first it crash with:

<?php
function test() {
    class C1 {
        use T1, T2 {
            T1::foo insteadof T2;
            T1::bar insteadof T2;
        }
    }
}

and you introduced a new no necessary flag.

I got a better fix, and committed in f039225

it also use less memory occupation.

please close this PR if you have no problems.

(sorry for delay, was busy with zend signals)

thanks

@reeze
Copy link
Contributor Author

reeze commented Mar 5, 2015

Great!

@reeze reeze closed this Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants