Fix GH-10521: ftp_get/ftp_nb_get resumepos offset is maximum 10GB#10525
Closed
ndossche wants to merge 1 commit intophp:PHP-8.1from
Closed
Fix GH-10521: ftp_get/ftp_nb_get resumepos offset is maximum 10GB#10525ndossche wants to merge 1 commit intophp:PHP-8.1from
ndossche wants to merge 1 commit intophp:PHP-8.1from
Conversation
Contributor
|
test is not passing on MacOS |
The char arrays were too small for a long on 64-bit systems, which resulted in cutting off the string at the end with a NUL byte. Use a size of MAX_LENGTH_OF_LONG to fix this issue instead of a fixed size of 11 chars.
Member
Author
Thanks for letting me know, should be fixed now. |
Member
Author
|
Christoph seems quite busy lately, shall we ask someone else for review too or is one reviewer good enough? :) |
iluuu1994
approved these changes
Mar 20, 2023
Member
|
Thanks 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-10521
The char arrays were too small for a long on 64-bit systems, which resulted in cutting off the string at the end with a NUL byte. Use a size of MAX_LENGTH_OF_LONG to fix this issue instead of a fixed size of 11 chars.