Allow comments between intersection types and by-ref params#10084
Closed
iluuu1994 wants to merge 1 commit intophp:masterfrom
Closed
Allow comments between intersection types and by-ref params#10084iluuu1994 wants to merge 1 commit intophp:masterfrom
iluuu1994 wants to merge 1 commit intophp:masterfrom
Conversation
54abed8 to
c74832f
Compare
|
As mentioned in the discussion on the chat, there's no non-greedy setting for re2c? For me it's totally fine to instead have without the MULTI_LINE_COMMENT. But maybe such an inconsistency would not be appreciated? I can also try https://stackoverflow.com/questions/11898998/how-can-i-write-a-regex-which-matches-non-greedy |
Member
Author
|
Allowing half the comments seems worse to me than no comments, as it's completely incomprehensive for end users... |
Member
Author
|
I don't think this is feasible until re2c properly supports lazy matching. |
This was referenced Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@olleharstedt Can you test if this works for you?