Fix GH-20840: crash on nested object with var_dump().#20843
Closed
devnexen wants to merge 1 commit intophp:PHP-8.4from
Closed
Fix GH-20840: crash on nested object with var_dump().#20843devnexen wants to merge 1 commit intophp:PHP-8.4from
devnexen wants to merge 1 commit intophp:PHP-8.4from
Conversation
Member
|
Does this actually need to error (it's a debugging-tool after all) or may we just print a placeholder and resume? I don't feel strongly either way, this is mostly a cosmetic fuzzer problem and should rarely occur in the real world. |
Member
Author
|
I can always write |
Member
|
Printing a placeholder would make sense 👍 Maybe something similar to "nesting level too deep" instead of "RECURSION", as the latter would imply that the structure is recursive. |
Member
Author
|
makes sense arnaud. I ll apply your suggestion later today. Cheers ! |
arnaud-lb
reviewed
Jan 9, 2026
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jan 9, 2026
mitigate it with stack check limit. close phpGH-20843
arnaud-lb
reviewed
Jan 9, 2026
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jan 9, 2026
mitigate it with stack check limit. close phpGH-20843
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jan 9, 2026
mitigate it with stack check limit. close phpGH-20843
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jan 9, 2026
mitigate it with stack check limit. close phpGH-20843
arnaud-lb
approved these changes
Jan 9, 2026
ext/standard/var.c
Outdated
Comment on lines
+83
to
+89
| level + 1, ' ', ZSTR_VAL(type_str)); | ||
| level + 1, ' ', ZSTR_VAL(type_str)); |
mitigate it with stack check limit. close phpGH-20843
iluuu1994
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mitigate it with stack check limit.