Autotools: Fix iconv shared build with external library#15686
Merged
petk merged 2 commits intophp:masterfrom Sep 1, 2024
Merged
Autotools: Fix iconv shared build with external library#15686petk merged 2 commits intophp:masterfrom
petk merged 2 commits intophp:masterfrom
Conversation
When building:
./configure --with-iconv=shared,/path/to/libiconv
the iconv couldn't be found due to linker error
Autoconf places LDFLAGS before the conftest.c file in the test compile
command and LIBS after it. GCC also requires this.
Similar issue discovered at
remicollet/php-xpass#1
devnexen
approved these changes
Sep 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building:
the iconv couldn't be found due to linker error
Autoconf places LDFLAGS before the conftest.c file in the test compile command and LIBS after it. GCC also requires this.
Similar issue discovered at
remicollet/php-xpass#1