random: Fix unknown mt_srand() compatibility for unknown modes
#13544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.1 and below interpreted unknown modes as `MT_RAND_MT19937`, but PHP 8.2+ interprets them as `MT_RAND_PHP`. Align the behavior with PHP 8.1 and below, because folks should be steered towards the standard mode.
8bf70af to
03bef8d
Compare
Member
Author
|
Duh. Forgot to |
Girgias
approved these changes
Feb 27, 2024
Member
Girgias
left a comment
There was a problem hiding this comment.
LGTM, might make sense to make this a ValueError in master.
Member
Author
|
Girgias
approved these changes
Feb 28, 2024
zeriyoshi
approved these changes
Feb 29, 2024
TimWolla
added a commit
that referenced
this pull request
Feb 29, 2024
Apparently PHP 8.2.17 was branched off after creating the PR and before merging it, placing the NEWS in the wrong location.
TimWolla
added a commit
that referenced
this pull request
Feb 29, 2024
* PHP-8.2: [ci skip] Fix version for GH-13544 in NEWS
TimWolla
added a commit
that referenced
this pull request
Feb 29, 2024
* PHP-8.3: [ci skip] Fix version for GH-13544 in NEWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://3v4l.org/fOZbQ. Will need some adjustments when merging to PHP 8.3, due to the deprecation.
Found, because I wondered about the implicit downcast from
zend_longtouint8_tduring the assignment ofmodeand wondered about that, because I contemplated making the two mode constants and enum in PHP 8.4+.PHP 8.1 and below interpreted unknown modes as
MT_RAND_MT19937, but PHP 8.2+ interprets them asMT_RAND_PHP.Align the behavior with PHP 8.1 and below, because folks should be steered towards the standard mode.