Remove support for custom assert() function

nikic · nikic · commit 55dbb573226c · 2019-01-29T11:10:47.000+01:00
Deprecated in PHP 7.3 as part of https://wiki.php.net/rfc/deprecations_php_7_3.
diff --git a/Zend/tests/custom_assert_forbidden.phpt b/Zend/tests/custom_assert_forbidden.phpt
@@ -9,4 +9,4 @@ function assert() {}
 
 ?>
 --EXPECTF--
-Deprecated: Defining a custom assert() function is deprecated, as the function has special semantics in %s on line %d
+Fatal error: Defining a custom assert() function is not allowed, as the function has special semantics in %s on line %d
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -5740,8 +5740,8 @@ static void zend_begin_func_decl(znode *result, zend_op_array *op_array, zend_as
 	}
 
 	if (zend_string_equals_literal_ci(unqualified_name, "assert")) {
-		zend_error(E_DEPRECATED,
-			"Defining a custom assert() function is deprecated, "
+		zend_error(E_COMPILE_ERROR,
+			"Defining a custom assert() function is not allowed, "
 			"as the function has special semantics");
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -5740,8 +5740,8 @@ static void zend_begin_func_decl(znode result, zend_op_array op_array, zend_as`
`5740`	`5740`	`}`
`5741`	`5741`
`5742`	`5742`	`if (zend_string_equals_literal_ci(unqualified_name, "assert")) {`
`5743`		`- zend_error(E_DEPRECATED,`
`5744`		`- "Defining a custom assert() function is deprecated, "`
	`5743`	`+ zend_error(E_COMPILE_ERROR,`
	`5744`	`+ "Defining a custom assert() function is not allowed, "`
`5745`	`5745`	`"as the function has special semantics");`
`5746`	`5746`	`}`
`5747`	`5747`