This repository was archived by the owner on Dec 8, 2021. It is now read-only.
Prevent the creation of new branches from random users #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I've done this too many times
Member
|
There has been normal usage of non-release branches on php-src - maybe we can prefix them with something like |
nikic
reviewed
Feb 27, 2021
| } | ||
|
|
||
| if ($pi->isNewBranch()) { | ||
| $authorizedUsers = $RMs + $weKnowWhatWeAreDoing; |
Member
There was a problem hiding this comment.
This doesn't do what you want it to do...
Member
|
This should probably be limited to php-src only? |
Member
I don't think we've used feature branches on php-src in a very long time. Nowadays it's expected that they will be on a fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I've done this too many times