fix: crash when a string is passed for the topics parameter of the mercure_publish() function #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcure_publish() function
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash that occurred when a string was passed as the topics parameter to the mercure_publish() function. The fix corrects the type handling in the Go implementation to properly extract string values from PHP's zval structures.
Key changes:
- Updated the
go_mercure_publishfunction signature to use proper C types (*C.zend_string) for string parameters - Fixed the string topic extraction from zval structures using the established pattern from the codebase
- Added comprehensive tests covering both string and array cases for the topics parameter
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mercure.go | Fixed function signature and type conversions; corrected zval string extraction for topics parameter |
| mercure_test.go | Added new test cases for mercure_publish with both module and worker modes |
| testdata/mercure-publish.php | Added test data demonstrating both string and array topic parameters |
| frankenphp_test.go | Extended test framework to support per-request options needed for Mercure hub configuration |
| testdata/flush.php | Removed extraneous blank line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.