fix: fail immediately on missing worker file #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henderkes
approved these changes
Nov 8, 2025
Contributor
henderkes
left a comment
There was a problem hiding this comment.
Good idea, won't spam logs with too many consecutive worker failures.
Member
|
Shouldn't we do that in the library directly? |
Contributor
Wouldn't that incur a runtime cost? This only runs during Caddy startup. Edit: wouldn't matter much, since it's only on restarts. |
Contributor
Author
|
Doing it like this seems cleanest to me since we just immediately return an error on |
dunglas
approved these changes
Nov 8, 2025
alexandre-daubois
approved these changes
Nov 10, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.