Skip to content

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Nov 3, 2025

Will allow to track FrankenPHP usage in the wild (currently, it is identified as Caddy).

cc @mholt

Copy link
Contributor

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many, many people remove the Server header unfortunately (for bizarre reasons), so I admit it's not a great metric, but it's worth a shot.

@henderkes
Copy link
Contributor

Cool idea, but don't most people disable server headers?

@mholt
Copy link
Contributor

mholt commented Nov 4, 2025

I dunno about most. But lots do I think. Disabling it has no benefit, mostly an old wives tale so to speak. But I still think it's worthwhile to set it.

# Conflicts:
#	caddy/module.go
#	frankenphp.go
@dunglas dunglas merged commit 724c0b1 into main Nov 10, 2025
24 checks passed
@dunglas dunglas deleted the feat/server-header branch November 10, 2025 16:25
@aleho
Copy link
Contributor

aleho commented Nov 25, 2025

I dunno about most. But lots do I think. Disabling it has no benefit, mostly an old wives tale so to speak. But I still think it's worthwhile to set it.

I've had to argue against external pen-testing providers contracted by customers because for them finding a Server header in a response is a "critical issue" (absurdly once for a service that is behind a proxy anyway).

I found your reasoning against removing the header some time ago in some discussion. Maybe a wiki entry one can point to like "See what the people behind Caddy officially think about your snake-oil" might help?

@dunglas
Copy link
Member Author

dunglas commented Nov 25, 2025

For the record, adding header -Server in the Caddyfile is what it takes to entirely remove the header if wanted.

@mholt
Copy link
Contributor

mholt commented Nov 25, 2025

@aleho Yikes, that's alarming... sigh.

Anyway, yeah, the header is easy to remove if insistent upon it. It just hurts the feedback cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants