Skip to content

ci: add PHP 8.5 support for building images #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dunglas merged 1 commit into from
Nov 19, 2025
Merged

ci: add PHP 8.5 support for building images #1932

dunglas merged 1 commit into from
Nov 19, 2025

Conversation

@vinceAmstoutz
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz commented Oct 17, 2025 •
edited
Loading

Fixes #1922 using the image tag php:8.5-rc, until the release of the stable version.

@vinceAmstoutz vinceAmstoutz force-pushed the feat/build-with-php-85 branch 3 times, most recently from f2e88bf to 837b47a Compare October 28, 2025 13:32
@vinceAmstoutz vinceAmstoutz marked this pull request as ready for review October 28, 2025 13:34
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Oct 28, 2025

@dunglas Any idea why these steps are failing? postgresql 🤔
Otherwise, most of the checks are green.

@dunglas
Copy link
Member

dunglas commented Oct 28, 2025

@vinceAmstoutz I'm not sure I could be a cache issue. Anyway it's unrelated as main is failing too.

@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Oct 29, 2025

Oh yes, there is a problem here: #1937. We used 80 GB of cache when the maximum is 10 GB, as explained by Github Actions in the error message here.

I can create a workflow that clears the cache on demand and/or automatically if you want, @dunglas.

@vinceAmstoutz vinceAmstoutz force-pushed the feat/build-with-php-85 branch from 837b47a to ade50ce Compare November 7, 2025 15:08
henderkes
henderkes approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dunglas dunglas merged commit 56df266 into php:main Nov 19, 2025
67 of 68 checks passed
@dunglas
Copy link
Member

dunglas commented Nov 19, 2025

Thanks, Vincent!

@vinceAmstoutz vinceAmstoutz deleted the feat/build-with-php-85 branch November 24, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

@henderkes henderkes henderkes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker tags for PHP alpha/beta/RC releases

3 participants

@vinceAmstoutz @dunglas @henderkes