Skip to content

fix: PHPValue() and GoValue() types #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dunglas merged 2 commits into from
Sep 15, 2025
Merged

fix: PHPValue() and GoValue() types #1879

dunglas merged 2 commits into from
Sep 15, 2025

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Sep 15, 2025

Fix a type issue I introduced in #1877

@dunglas dunglas changed the title fix: PHPValue() return type fix: PHPValue() and GoValue() types Sep 15, 2025
withinboredom
withinboredom approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@withinboredom withinboredom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:try-not-to-cry.gif:

@dunglas dunglas merged commit 7754abc into main Sep 15, 2025
23 checks passed
@dunglas dunglas deleted the fix/PHPValue-type branch September 15, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@withinboredom withinboredom withinboredom approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dunglas @withinboredom @alexandre-daubois