feat(worker): make maximum consecutive failures configurable #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eef1c5c to
f37aaf8
Compare
dunglas
requested changes
Jun 26, 2025
8ac24e5 to
95c4fdd
Compare
Contributor
|
I think workers will only fail on startup, so not sure if there's much benefit to fine-tuning that failure limit. I would agree though that disabling the failing entirely might be a valid use case. Also, it would be nice to have something like a frankenphp.WithWorkers(
fileName,
num,
WithWorkerEnv(...),
WithWorkerWatchMode(...),
WithWorkerMaxFailures(...),
) |
3d3d831 to
0b512db
Compare
Member
Author
|
Good idea, I implemented functional options |
dunglas
requested changes
Jun 27, 2025
0b512db to
03ce7e2
Compare
dunglas
approved these changes
Jun 27, 2025
dunglas
requested changes
Jun 27, 2025
frankenphp_test.go
Outdated
| workerOpts := []frankenphp.WorkerOption{ | ||
| frankenphp.WithWorkerEnv(opts.env), | ||
| frankenphp.WithWorkerWatchMode(opts.watch), | ||
| frankenphp.WithWorkerMaxFailures(6), |
Member
There was a problem hiding this comment.
Suggested change
| frankenphp.WithWorkerMaxFailures(6), |
options.go
Outdated
| func WithWorkerMaxFailures(maxFailures int) WorkerOption { | ||
| return func(w *workerOpt) { | ||
| if maxFailures < -1 { | ||
| maxFailures = DefaultMaxConsecutiveFailures |
Member
There was a problem hiding this comment.
We should return an error here instead of silently ignoring the invalid value
Member
Author
There was a problem hiding this comment.
Alright, I updated all functions to return an error
phpmainthread_test.go
Outdated
| workers = make(map[string]*worker) | ||
| _, err1 := newWorker(workerOpt{fileName: "filename.php"}) | ||
| _, err2 := newWorker(workerOpt{fileName: "filename.php"}) | ||
| _, err1 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: 6}) |
Member
There was a problem hiding this comment.
Suggested change
| _, err1 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: 6}) | |
| _, err1 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: DefaultMaxConsecutiveFailures}) |
phpmainthread_test.go
Outdated
| _, err1 := newWorker(workerOpt{fileName: "filename.php"}) | ||
| _, err2 := newWorker(workerOpt{fileName: "filename.php"}) | ||
| _, err1 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: 6}) | ||
| _, err2 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: 6}) |
Member
There was a problem hiding this comment.
Suggested change
| _, err2 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: 6}) | |
| _, err2 := newWorker(workerOpt{fileName: "filename.php", maxConsecutiveFailures: DefaultMaxConsecutiveFailures}) |
phpmainthread_test.go
Outdated
Comment on lines
202
to
203
| _, err1 := newWorker(workerOpt{fileName: "filename.php", name: "workername", maxConsecutiveFailures: 6}) | ||
| _, err2 := newWorker(workerOpt{fileName: "filename2.php", name: "workername", maxConsecutiveFailures: 6}) |
Member
There was a problem hiding this comment.
Suggested change
| _, err1 := newWorker(workerOpt{fileName: "filename.php", name: "workername", maxConsecutiveFailures: 6}) | |
| _, err2 := newWorker(workerOpt{fileName: "filename2.php", name: "workername", maxConsecutiveFailures: 6}) | |
| _, err1 := newWorker(workerOpt{fileName: "filename.php", name: "workername", maxConsecutiveFailures: DefaultMaxConsecutiveFailures}) | |
| _, err2 := newWorker(workerOpt{fileName: "filename2.php", name: "workername", maxConsecutiveFailures: DefaultMaxConsecutiveFailures}) |
phpmainthread_test.go
Outdated
| num: 1, | ||
| fileName: testDataPath + "/" + fileName, | ||
| num: 1, | ||
| maxConsecutiveFailures: 6, |
Member
There was a problem hiding this comment.
Suggested change
| maxConsecutiveFailures: 6, | |
| maxConsecutiveFailures: DefaultMaxConsecutiveFailures, |
options.go
Outdated
| ) | ||
|
|
||
| // DefaultMaxConsecutiveFailures is the default maximum number of consecutive failures before panicking | ||
| const DefaultMaxConsecutiveFailures = 6 |
Member
There was a problem hiding this comment.
This could be unexported, this isn't used outside of the frankenphp package
03ce7e2 to
648196f
Compare
dunglas
approved these changes
Jun 30, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new configuration key to configure max consecutive failures for workers: