Conversation
cmb69
left a comment
There was a problem hiding this comment.
Thank you! I think it is okay, but consider my comments.
cmb69
left a comment
There was a problem hiding this comment.
Besides the missing stringable/tostring.xml, there are more issues:
- commenting out the xi:includes accidentially commented out the
</classsynopsis>tag - the stringable page needs to be added to languages/predefined/interfaces.xml (and then the methodsynopses should be included again (i.e. only comment out the contructorsysnopses)
- there should be an entry in languages/predefined/versions.xml
Could you please take a look, @Crell?
|
@cmb69: I just came across https://www.php.net/stringable and looking for a reason that the I noted you referred to "commenting out the xi:includes" in your previous comment but it still wasn't clear to me what you meant by that, as I didn't find discussion about commenting that out in any previously resolved comments. Perhaps it wasn't possible to link to |
That documentation needs yet to be written (the PR has a respective comment); until this file is in place, the Anyhow, a PR would be welcome! |
I think that covers it, but please make sure I didn't miss a step...