Skip to content

Note that all visibilities of trait abstract methods are supported.#476

Closed
Crell wants to merge 2 commits intophp:masterfrom
Crell:trait-private-method
Closed

Note that all visibilities of trait abstract methods are supported.#476
Crell wants to merge 2 commits intophp:masterfrom
Crell:trait-private-method

Conversation

@Crell
Copy link
Copy Markdown
Contributor

@Crell Crell commented Mar 4, 2021

The docs didn't specify before, so I just clarified that it does now work on all of them.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Mar 8, 2021

The word "now" appears to be important here. Please clarify that private is supported only as of PHP 8.0.0.

@Crell
Copy link
Copy Markdown
Contributor Author

Crell commented Mar 8, 2021

Done.

Copy link
Copy Markdown
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@php-pulls php-pulls closed this in 77a77db Mar 10, 2021
@Crell Crell deleted the trait-private-method branch April 7, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants