Fix return type of date_sun_info() #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function no longer returns false since PHP 8. Also, "success" for this function means calling the function with three arguments of the correct type. - https://github.com/php/php-src/blob/php-7.0.0/ext/date/php_date.c#L4725-L4737 - https://github.com/php/php-src/blob/php-7.4.0/ext/date/php_date.c#L5077-L5094 Therefore, only `array` was consistently written in the return value of the prototype.
Girgias
reviewed
Feb 28, 2024
Member
Girgias
left a comment
There was a problem hiding this comment.
Was the false return due to ZPP failures?
Member
Yes: php/php-src@647b1c7 |
Girgias
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function no longer returns false since PHP 8.
Also, "success" for this function means calling the function with three arguments of the correct type.
Therefore, only
arraywas consistently written in the return value of the prototype.