Merged
Conversation
ndossche
reviewed
Oct 3, 2023
Member
ndossche
left a comment
There was a problem hiding this comment.
Changes look good.
I just have to check whether false can actually be passed, and if so, in which cases...
ndossche
requested changes
Oct 3, 2023
reference/xml/functions/xml-set-external-entity-ref-handler.xml
Outdated
Show resolved
Hide resolved
reference/xml/functions/xml-set-external-entity-ref-handler.xml
Outdated
Show resolved
Hide resolved
reference/xml/functions/xml-set-processing-instruction-handler.xml
Outdated
Show resolved
Hide resolved
reference/xml/functions/xml-set-start-namespace-decl-handler.xml
Outdated
Show resolved
Hide resolved
reference/xml/functions/xml-set-unparsed-entity-decl-handler.xml
Outdated
Show resolved
Hide resolved
reference/xml/functions/xml-set-unparsed-entity-decl-handler.xml
Outdated
Show resolved
Hide resolved
ndossche
approved these changes
Oct 4, 2023
Member
ndossche
left a comment
There was a problem hiding this comment.
LGTM, thanks.
One minor thing that can be improved, is the example of xml_set_object.
I noticed it has a destructor function, but that's not needed as xml_parser_free does nothing anymore, and the unsetting is useless as well. So removing that function would make the example a bit tidier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the last remaining usage of the
¬e.func-callback;language snippet.