Skip to content

Add PhpToken reference#272

Closed
jiripudil wants to merge 2 commits intophp:masterfrom
jiripudil:phptoken
Closed

Add PhpToken reference#272
jiripudil wants to merge 2 commits intophp:masterfrom
jiripudil:phptoken

Conversation

@jiripudil
Copy link
Copy Markdown
Contributor

No description provided.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Dec 8, 2020

Very nice, thank you very much! The only change I'm going to apply on top of this is the use of ?string; nullable types should be written as union types; it would be nice, though, if PhD would render them with the question mark.

@php-pulls php-pulls closed this in 82c84a3 Dec 8, 2020
@jiripudil jiripudil deleted the phptoken branch December 9, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants