Skip to content

Add new IntlDateFormatter constants.#267

Closed
Crell wants to merge 3 commits intophp:masterfrom
Crell:intldateformatter
Closed

Add new IntlDateFormatter constants.#267
Crell wants to merge 3 commits intophp:masterfrom
Crell:intldateformatter

Conversation

@Crell
Copy link
Copy Markdown
Contributor

@Crell Crell commented Dec 3, 2020

I'm not certain of the "right" way to denote the version for these. I'd think a Changelog block, but that looks non-small to add from a quick glance at other pages.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Dec 3, 2020

Usually, for constants there is just a "Available as of PHP x.y.z." sentence at the end of the description.

@Crell
Copy link
Copy Markdown
Contributor Author

Crell commented Dec 4, 2020

Works for me. Updated.

@php-pulls php-pulls closed this in 80858f3 Dec 6, 2020
@Crell Crell deleted the intldateformatter branch April 30, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants