Add createFromInterface() for DateTime objects.#257
Closed
Crell wants to merge 1 commit intophp:masterfrom
Closed
Conversation
cmb69
approved these changes
Dec 10, 2020
Member
cmb69
left a comment
There was a problem hiding this comment.
Thank you!
I left two comments regarding changes which I did right away. :)
| <function name="datetime::add" from="PHP 5 >= 5.3.0, PHP 7"/> | ||
| <function name="datetime::createfromformat" from="PHP 5 >= 5.3.0, PHP 7"/> | ||
| <function name="datetime::createfromimmutable" from="PHP 7 >= 7.3.0"/> | ||
| <function name="datetime::createfrominterface" from="PHP 8 >= 8.0.0"/> |
Member
There was a problem hiding this comment.
No need to add any x.0.0 revision:
Suggested change
| <function name="datetime::createfrominterface" from="PHP 8 >= 8.0.0"/> | |
| <function name="datetime::createfrominterface" from="PHP 8"/> |
| </para> | ||
| </refsect1> | ||
|
|
||
| <refsect1 role="returnvalues"> |
Member
There was a problem hiding this comment.
The returnvalues sections should be placed before the examples section (I've noticed that this is not the case for some other date related pages, what should ideally be fixed sometime).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the same file for both. Hopefully I caught all the places to reverse the class names... 😃