Add chapter on Attributes in language section.#254
Closed
beberlei wants to merge 3 commits intophp:masterfrom
Closed
Add chapter on Attributes in language section.#254beberlei wants to merge 3 commits intophp:masterfrom
beberlei wants to merge 3 commits intophp:masterfrom
Conversation
Girgias
requested changes
Dec 1, 2020
Member
Girgias
left a comment
There was a problem hiding this comment.
Can't comment on the general text as I don't really understand the feature, but the usage of you should be avoided in the docs. So if you could change that that would be great. :)
Comment on lines
+11
to
+12
| on declarations in code: Classes, methods, functions, parameters, | ||
| properties and constants can be the target of an attribute. The metadata |
Member
There was a problem hiding this comment.
Should we add links to the relevant pages?
Member
There was a problem hiding this comment.
Might be more noise than actually being useful.
cmb69
approved these changes
Dec 4, 2020
Member
cmb69
left a comment
There was a problem hiding this comment.
Thank you! Besides the few nits, I think this is good to be merged. The rest of the documentation updates can be done later.
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not particularly good at documneting things, but this is an acceptable start I hope, for the Attributes feature. it covers the basics:
A bunch of things are missing for now:
Thingand suchReflectionAttributeclass in reflection bookgetArguments()methods in every relevant reflection componentafter merging this, doc-base needs a small patch to render this: