Skip to content

Document the ::class constant on objects.#239

Closed
Crell wants to merge 4 commits intophp:masterfrom
Crell:object-class
Closed

Document the ::class constant on objects.#239
Crell wants to merge 4 commits intophp:masterfrom
Crell:object-class

Conversation

@Crell
Copy link
Copy Markdown
Contributor

@Crell Crell commented Nov 25, 2020

Not much else to say here.

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit and a comment

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias
Copy link
Copy Markdown
Member

Girgias commented Nov 27, 2020

A quick git grep search shows that the XML ID is already in use here:
language/oop5/basic.xml: <example xml:id="language.oop5.basic.class.class.name"> and is the only usage of it (no references) so renaming that example ID could be a solution.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Nov 27, 2020

@Crell, the main difference between <example> and <informalexample> is that the former requires a <title> while the latter must not have any (there may also be differences how that is handled by PhD). As such my suggestion was bad. The actual problem have been the duplicated IDs (as pointed out by @Girgias).

@php-pulls php-pulls closed this in 370bb99 Nov 27, 2020
@Crell Crell deleted the object-class branch April 30, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants