Skip to content

Exception updates#238

Closed
Crell wants to merge 8 commits intophp:masterfrom
Crell:empty-catch
Closed

Exception updates#238
Crell wants to merge 8 commits intophp:masterfrom
Crell:empty-catch

Conversation

@Crell
Copy link
Copy Markdown
Contributor

@Crell Crell commented Nov 25, 2020

  • Empty catch statements
  • Throw as an expression
  • Various other cleanup while I was there to remove comments

I also deleted a crapload of comments. It's so satisfying.

Girgias
Girgias approved these changes Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmb69
cmb69 reviewed Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall very nice work. :)

@php-pulls php-pulls closed this in 1d58f72 Nov 25, 2020
@Crell Crell deleted the empty-catch branch November 26, 2020 20:23
@Girgias Girgias mentioned this pull request Jun 9, 2021
Closed
@tiffany-taylor tiffany-taylor mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 left review comments

@Girgias Girgias Girgias approved these changes

+1 more reviewer

@DaveRandom DaveRandom DaveRandom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Crell @cmb69 @DaveRandom @Girgias