Added documentation for the get_resource_id function#227
Closed
emmanix2002 wants to merge 1 commit intophp:masterfrom
Closed
Added documentation for the get_resource_id function#227emmanix2002 wants to merge 1 commit intophp:masterfrom
emmanix2002 wants to merge 1 commit intophp:masterfrom
Conversation
Author
Member
|
Thank you! Minor nit: please avoid unrelated whitespace changes, since that makes it harder for the translators. |
Author
Noted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the documentation for
get_resource_idaccording to what we have here: https://php.watch/versions/8.0/get_resource_id and the implementation in https://github.com/php/php-src/pull/5427/files (only needed this to confirm the parameter name)