Added documentation for the str_contains#216
Closed
emmanix2002 wants to merge 3 commits intophp:masterfrom
Closed
Conversation
Girgias
requested changes
Nov 23, 2020
Member
Girgias
left a comment
There was a problem hiding this comment.
Remove the .gitignore file as the docs are backed up by SVN
XML indentation is 1 space, PHP examples 4 space indentation
Modifying the See Also sections of other functions to point to this one would be a good idea
Author
Got it |
Member
|
Please also add a respective entry to https://github.com/php/doc-en/blob/master/reference/strings/versions.xml. |
- Added function reference to the see also section of some related functions - Reduced XML indentation to 1 space char and updated examples
Author
Author
Author
@Girgias Fixed |
Member
|
Very nice, thanks! Applied as http://svn.php.net/viewvc?view=revision&revision=351548. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation for
str_containsbased on the RFC https://wiki.php.net/rfc/str_contains