Skip to content

PHP 8.0 migration guide#170

Closed
cmb69 wants to merge 24 commits intophp:masterfrom
cmb69:cmb/migration80
Closed

PHP 8.0 migration guide#170
cmb69 wants to merge 24 commits intophp:masterfrom
cmb69:cmb/migration80

Conversation

@cmb69
Copy link
Copy Markdown
Member

@cmb69 cmb69 commented Oct 29, 2020

This is a follow-up to PR #164 which I've screwed up unrepairably.

@cmb69 cmb69 added the help wanted Extra attention is needed label Nov 1, 2020
@carusogabriel
Copy link
Copy Markdown
Contributor

@sgolemon Wanna take a look as well?

Copy link
Copy Markdown
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document that all the deprecated stuff from PHP 7.x were removed as well?

php/php-src#3770

@cmb69
Copy link
Copy Markdown
Member Author

cmb69 commented Nov 3, 2020

Should we document that all the deprecated stuff from PHP 7.x were removed as well?

At least most of that should already be there in https://github.com/php/doc-en/pull/170/files#diff-dc046224091f8e12cac61d0f1373afa026a8425c1dac1032440080786e77f047. Might be sensible to double-check.

PS: I've checked php/php-src#3770, and added the missing "Defining a free-standing assert() function". All others should be already documented.

@cmb69
Copy link
Copy Markdown
Member Author

cmb69 commented Nov 8, 2020

The union type documentation would be available with PR #174.

Copy link
Copy Markdown
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this and continue iterating in-tree.

Only thing I'd suggest is to maybe merge the Windows section into appropriate other places. E.g. the proc_open one into incompatible changes, and the other two into other changes).

@cmb69
Copy link
Copy Markdown
Member Author

cmb69 commented Nov 8, 2020

Thanks, @nikic! However, I have some concerns to merge this wrt. translations. Even if we add a note to the commit message that this is work in progress and should not be translated yet, translators may overlook or ignore that, and might have a hard time to follow up on changes. And I'm afraid there is the need for a lot of changes; for instance, I've just noticed that PhD apperently does not support linking to arbitrary elements, so it seems that we need <sect3> elements instead of the <listitems> (or patch PhD), and that would require restructuring (and maybe also some reordering). At least linking to the most prominent features/changes should be possible (e.g. to link from the release announcements).

@cmb69
Copy link
Copy Markdown
Member Author

cmb69 commented Nov 22, 2020

I have added subsections for the most relevant changes, integrated the Windows section into incompatible, added a few links to documentation available in the meantime, and applied as http://svn.php.net/viewvc?view=revision&revision=351500.

@cmb69 cmb69 closed this Nov 22, 2020
@cmb69 cmb69 deleted the cmb/migration80 branch November 22, 2020 18:31
@cmb69 cmb69 removed the help wanted Extra attention is needed label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants