Conversation
8a4090a to
18112d7
Compare
|
@sgolemon Wanna take a look as well? |
carusogabriel
left a comment
There was a problem hiding this comment.
Should we document that all the deprecated stuff from PHP 7.x were removed as well?
At least most of that should already be there in https://github.com/php/doc-en/pull/170/files#diff-dc046224091f8e12cac61d0f1373afa026a8425c1dac1032440080786e77f047. Might be sensible to double-check. PS: I've checked php/php-src#3770, and added the missing "Defining a free-standing assert() function". All others should be already documented. |
|
The union type documentation would be available with PR #174. |
nikic
left a comment
There was a problem hiding this comment.
I think we should merge this and continue iterating in-tree.
Only thing I'd suggest is to maybe merge the Windows section into appropriate other places. E.g. the proc_open one into incompatible changes, and the other two into other changes).
|
Thanks, @nikic! However, I have some concerns to merge this wrt. translations. Even if we add a note to the commit message that this is work in progress and should not be translated yet, translators may overlook or ignore that, and might have a hard time to follow up on changes. And I'm afraid there is the need for a lot of changes; for instance, I've just noticed that PhD apperently does not support linking to arbitrary elements, so it seems that we need |
f98f9bc to
96732ae
Compare
Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
3e87fbe to
57c0bed
Compare
|
I have added subsections for the most relevant changes, integrated the Windows section into incompatible, added a few links to documentation available in the meantime, and applied as http://svn.php.net/viewvc?view=revision&revision=351500. |
This is a follow-up to PR #164 which I've screwed up unrepairably.