FilesystemIterator bug in PHP 8.2#1685
Merged
mrook merged 40 commits intophingofficial:mainfrom Oct 13, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
=========================================
Coverage 58.34% 58.34%
Complexity 6961 6961
=========================================
Files 355 355
Lines 16611 16612 +1
=========================================
+ Hits 9692 9693 +1
Misses 6919 6919
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before PHP 8.2, the flag
FilesystemIterator::SKIP_DOTSwas always set, according to FilesystemIterator documentation:FilesystemIteratorhas changed its behavior in PHP 8.2.Here an example (also in https://3v4l.org/HrmZ2):
This is the output in PHP 8.1:
However in PHP 8.2 this behavior has changed:
Example
Output: