Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

fix: GITHUB_OUTPUT doesn't need {}#150

Merged
Jeroen Knoops (JeroenKnoops) merged 1 commit intophilips-software:mainfrom
rjaegers:main
Oct 25, 2022
Merged

fix: GITHUB_OUTPUT doesn't need {}#150
Jeroen Knoops (JeroenKnoops) merged 1 commit intophilips-software:mainfrom
rjaegers:main

Conversation

@rjaegers
Copy link
Copy Markdown
Member

Using the output variables in a job is broken after the changes to GITHUB_OUTPUT as can be seen in https://github.com/philips-internal/amp-connectivity-devcontainer/pull/20.

The GitHub documentation is a bit misleading in this respect. See: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter.

The shell snippet looks like this:

echo "{name}={value}" >> $GITHUB_OUTPUT

While the example looks like this:

      - name: Set color
        id: random-color-generator
        run: echo "SELECTED_COLOR=green" >> $GITHUB_OUTPUT
      - name: Get color
        run: echo "The selected color is ${{ steps.random-color-generator.outputs.SELECTED_COLOR }}"

I have removed all parenthesis in this PR.

@rjaegers Ron (rjaegers) requested a review from a team as a code owner October 25, 2022 06:04
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are amazing!

@JeroenKnoops Jeroen Knoops (JeroenKnoops) merged commit 75cafd6 into philips-software:main Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants