This repository was archived by the owner on Nov 24, 2025. It is now read-only.
fix: GITHUB_OUTPUT doesn't need {}#150
Merged
Jeroen Knoops (JeroenKnoops) merged 1 commit intophilips-software:mainfrom Oct 25, 2022
rjaegers:main
Merged
fix: GITHUB_OUTPUT doesn't need {}#150Jeroen Knoops (JeroenKnoops) merged 1 commit intophilips-software:mainfrom rjaegers:main
Jeroen Knoops (JeroenKnoops) merged 1 commit intophilips-software:mainfrom
rjaegers:main
Conversation
Jeroen Knoops (JeroenKnoops)
approved these changes
Oct 25, 2022
Member
Jeroen Knoops (JeroenKnoops)
left a comment
There was a problem hiding this comment.
You are amazing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the output variables in a job is broken after the changes to GITHUB_OUTPUT as can be seen in https://github.com/philips-internal/amp-connectivity-devcontainer/pull/20.
The GitHub documentation is a bit misleading in this respect. See: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter.
The shell snippet looks like this:
While the example looks like this:
I have removed all parenthesis in this PR.