This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Rename variables related to registry#135
Closed
Jeroen van Gastel (vanGastelJS) wants to merge 1 commit intophilips-software:mainfrom
vanGastelJS:Feature/34_RemaveDockerVariables
Closed
Rename variables related to registry#135Jeroen van Gastel (vanGastelJS) wants to merge 1 commit intophilips-software:mainfrom vanGastelJS:Feature/34_RemaveDockerVariables
Jeroen van Gastel (vanGastelJS) wants to merge 1 commit intophilips-software:mainfrom
vanGastelJS:Feature/34_RemaveDockerVariables
Conversation
Updated LICENSE.md to extend copyright to include current year
Member
|
Thank you for contributing Jeroen van Gastel (@vanGastelJS), this looks great! This is quite a severe breaking change. For this reason, I would like to wait for the main maintainer Jeroen Knoops (@JeroenKnoops). |
Member
|
Looks good. We have to make sure it's clear in the release notes as this is breaking change. |
Member
|
I will add a version in between with a deprecation warning.. |
Member
|
Testing the release in: https://github.com/philips-software/docker-node/actions/runs/2963311948 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per suggestion of #34 , renamed variables related to docker image registry.
Renamed variables:
Also derived internal variable names are renamed according to the renaming above.
Also update LICENSE.md to extend copyright to include current year