Merged
Conversation
no desugaring any more
Doesn't correctly handle the case where the replacement is itself interpolated text, hence the ignored test for now.
Previously, `Text/replace "foo" "bar${x}baz" "foofoo"` did not work as
expected. This fixes it by extracting the code from eval.go that
deals with evaluating Text into a textValBuilder struct, and then
reusing that textValBuilder in the Text/replace implementation.
This pins us to a dhall-lang commit just after
dhall-lang/dhall-lang#1084 was merged; this is
the same as verison 19.0.0 with a fix for
TestNormalization/unit/TextReplaceAbstractA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.