Skip to content

Revert "Use taskbar icon name for inspector and playground"#779

Merged
Ducasse merged 1 commit intoPharo13from
revert-771-use-taskbar-icon-name
Jun 14, 2024
Merged

Revert "Use taskbar icon name for inspector and playground"#779
Ducasse merged 1 commit intoPharo13from
revert-771-use-taskbar-icon-name

Conversation

@Ducasse
Copy link
Contributor

@Ducasse Ducasse commented Jun 14, 2024

Reverts #771

I will revert this PR since it breaks Pharo

Form(Object)>>doesNotUnderstand: #asSymbol
ThemeIcons>>iconFormSetNamed:ifNone:
ThemeIcons>>iconFormSetNamed:
TaskbarItemMorph(Object)>>iconFormSetNamed:
TaskbarItemMorph>>initializeFor:
PharoLightTheme(UITheme)>>newTaskbarButtonIn:forTask:
TaskbarTask>>taskbarButtonFor:
[:t | | button |
		button := t taskbarButtonFor: self.
		button ifNotNil: [self addMorphBack: button]] in TaskbarMorph>>updateTaskButtons in Block: [:t | | button |...
OrderedCollection>>do:
TaskbarMorph>>updateTaskButtons
TaskbarMorph>>updateTasks
[self updateBounds.
	self updateTasks] in TaskbarMorph>>ownerChanged in Block: [self updateBounds....
FullBlockClosure(BlockClosure)>>on:do:
TaskbarMorph>>ownerChanged
[:m | m ownerChanged] in WorldMorph(Morph)>>doLayoutIn: in Block: [:m | m ownerChanged]
Array(SequenceableCollection)>>do:
WorldMorph(Morph)>>doLayoutIn:
WorldMorph(Morph)>>computeFullBounds
WorldMorph(Morph)>>fullBounds
MorphicEventDispatcher>>dispatchDefault:with:
MorphicEventDispatcher>>handleMouseMove:
MouseMoveEvent>>sentTo:
[ ^ anEvent sentTo: self ] in MorphicEventDispatcher>>dispatchEvent:with: in Block: [ ^ anEvent sentTo: self ]
FullBlockClosure(BlockClosure)>>ensure:
MorphicEventDispatcher>>dispatchEvent:with:
WorldMorph(Morph)>>processEvent:using:
WorldMorph(Morph)>>processEvent:
HandMorph>>sendEvent:focus:clear:
HandMorph>>sendMouseEvent:
HandMorph>>handleEvent:
[
		(morphicWorld activeHand isNotNil and: [ anEvent hand isNotNil ]) ifTrue: [
			morphicWorld activeHand handleEvent: anEvent
		]
	] in OSWindowMorphicEventHandler>>dispatchMorphicEvent: in Block: [...
WorldState>>runStepMethodsIn:
WorldMorph>>runStepMethods
WorldState>>doOneCycleFor:
WorldMorph>>doOneCycleNow
WorldMorph>>doOneCycle
[
		| extraWorldsToDraw |
		extraWorldsToDraw := ExtraWorldListMutex critical: [
			                     self extraWorldList ].
		extraWorldsToDraw do: [ :world | world doOneCycle ].

		(self currentWorld isNotNil and: [
			 (extraWorldsToDraw includes: self currentWorld) not ]) ifTrue: [
			self currentWorld doOneCycle ] ] in WorldMorph class>>doOneCycle in Block: [...
FullBlockClosure(BlockClosure)>>ensure:
WorldState class>>doDrawCycleWith:
WorldMorph class>>doOneCycle
MorphicRenderLoop>>doOneCycle
MorphicRenderLoop>>doOneCycleWhile:
[ MorphicRenderLoop new doOneCycleWhile: [ true ] ] in MorphicUIManager>>spawnNewProcess in Block: [ MorphicRenderLoop new doOneCycleWhile: [ tru[..]
[self value.
			"IMPORTANT: Do not step over next line of code. See method comments for details"
			Processor terminateRealActive] in FullBlockClosure(BlockClosure)>>newProcess in Block: [self value....

@Ducasse Ducasse merged commit b6eb083 into Pharo13 Jun 14, 2024
@badetitou
Copy link
Contributor

Hello

I suppose there was an not tested case.
Can you explain how I can reproduce the bugs you had? So I'll try to understand and fix and add tests

@Ducasse
Copy link
Contributor Author

Ducasse commented Jun 16, 2024

Just loading the PR and trying to open iceberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants