Skip to content

test file dialogs returns the selected file#778

Merged
jecisc merged 1 commit intopharo-spec:Pharo13from
demarey:Pharo13
Jun 14, 2024
Merged

test file dialogs returns the selected file#778
jecisc merged 1 commit intopharo-spec:Pharo13from
demarey:Pharo13

Conversation

@demarey
Copy link
Contributor

@demarey demarey commented Jun 13, 2024

No description provided.

@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

Two tests are failing

StOpenFilePresenterTest
 ✗ #testSelectFile (166ms)

StOpenDirectoryPresenterTest
 ✗ #testSelectDirectory (231ms)

@Ducasse Ducasse added the need more work This needs to be improved before being considered label Jun 13, 2024
@demarey
Copy link
Contributor Author

demarey commented Jun 13, 2024

Probably the change in spec is not yet in the image (need to wait next Pharo build).

@demarey demarey closed this Jun 14, 2024
@demarey demarey reopened this Jun 14, 2024
@demarey demarey removed the need more work This needs to be improved before being considered label Jun 14, 2024
@jecisc jecisc merged commit 1afd65d into pharo-spec:Pharo13 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jecisc jecisc jecisc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@demarey @Ducasse @jecisc