Skip to content

Make setting pages less dense without comments for each setting#772

Merged
demarey merged 3 commits intopharo-spec:Pharo13from
hernanmd:setting_doc_as_tooltips
Jun 14, 2024
Merged

Make setting pages less dense without comments for each setting#772
demarey merged 3 commits intopharo-spec:Pharo13from
hernanmd:setting_doc_as_tooltips

Conversation

@hernanmd
Copy link
Member

@hernanmd hernanmd commented Jun 6, 2024

This PR includes two main changes to have better setting documentation in the New Settings Browser:

  • Remove explicit documentation presenter below each setting. It makes loading settings a lot faster.
  • Better class names for setting presenters.
Screenshot 2024-06-06 at 16 23 39

Remove explicit documentation presenter below each setting. It makes …
a76dde7 
…loading settings a lot faster.

Better class names for setting presenters.
@hernanmd hernanmd self-assigned this Jun 6, 2024
@hernanmd hernanmd added the enhancement New feature or request label Jun 6, 2024
@hernanmd hernanmd requested review from demarey and jecisc June 6, 2024 14:30
@demarey
Copy link
Contributor

demarey commented Jun 6, 2024

I like it. It is better than the previous layout but now, it misses the documentation.
As discussed, you could define the right panel with newPanedLayoutTopToBottom: and add the documentation at the bottom side + set the position of slider to 80 percent by example.

@hernanmd
Copy link
Member Author

hernanmd commented Jun 6, 2024

I like it. It is better than the previous layout but now, it misses the documentation. As discussed, you could define the right panel with newPanedLayoutTopToBottom: and add the documentation at the bottom side + set the position of slider to 80 percent by example.

Yes, step by step :)
I will add it in another issue/PR so I don't make this one too big.

Add a new presenter within the setting category page.
d9e3843 
When a setting input presenter is focused, the new presenter displays the currently selected setting label and its help text (if present).
Clean leftovers.
@Ducasse Ducasse closed this Jun 13, 2024
@Ducasse Ducasse reopened this Jun 13, 2024
@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024 

StSettingsBrowserTest
 ✗ #testSimulateCategorySelection (42ms)

@Ducasse Ducasse added the need more work This needs to be improved before being considered label Jun 13, 2024
@demarey demarey merged commit d47c3ba into pharo-spec:Pharo13 Jun 14, 2024
@hernanmd hernanmd deleted the setting_doc_as_tooltips branch June 20, 2024 18:05
@hernanmd hernanmd mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demarey demarey Awaiting requested review from demarey

@jecisc jecisc Awaiting requested review from jecisc

Assignees

@hernanmd hernanmd

Labels

enhancement New feature or request need more work This needs to be improved before being considered

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hernanmd @demarey @Ducasse