Skip to content

adding test to ensure it is possible to recompile code within a bloc with a dead home context twice#723

Merged
Ducasse merged 1 commit intopharo-spec:Pharo13from
adri09070:722-DebuggerP12-Recompiling-code-within-a-bloc-cannot-be-done-more-than-once-in-the-debugger
Jun 14, 2024
Merged

adding test to ensure it is possible to recompile code within a bloc with a dead home context twice#723
Ducasse merged 1 commit intopharo-spec:Pharo13from
adri09070:722-DebuggerP12-Recompiling-code-within-a-bloc-cannot-be-done-more-than-once-in-the-debugger

Conversation

@adri09070
Copy link
Contributor

Fixes #722

Test corresponding to this PR that needs to be merged first: pharo-project/pharo#16319

@adri09070 adri09070 added bug Something isn't working debugger labels Mar 20, 2024
@adri09070
Copy link
Contributor Author

@StevenCostiou

@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

Hi @adri09070
This test is failing

StDebuggerActionModelTest
 ✗ #testRecompileMethodToInBlockContextWithDeadHomeTwice (7ms)
TestFailure: Got 'methodWithDeadBlockContext

	^ [ (1 + 1) printString ] yourself' instead of 'methodWithDeadBlockContext

	^ [ (1 + 1) printString ] yourself yourself'.
StDebuggerActionModelTest(TestAsserter)>>assert:description:resumable:
StDebuggerActionModelTest(TestAsserter)>>assert:description:
StDebuggerActionModelTest(TestAsserter)>>assert:equals:
StDebuggerActionModelTest>>testRecompileMethodToInBlockContextWithDeadHomeTwice ...assert: (self class >> #methodWithDeadBlockContext) ast sourceCode
		equals: methodWithBlockContextOriginalSource , ' yourself yourself'
StDebuggerActionModelTest(TestCase)>>performT

@adri09070
Copy link
Contributor Author

Hi @Ducasse

Yes, this is because pharo-project/pharo#16319 should be merged first. That's why I put it to draft

@Ducasse Ducasse marked this pull request as ready for review June 13, 2024 07:52
@Ducasse Ducasse closed this Jun 13, 2024
@Ducasse Ducasse reopened this Jun 13, 2024
@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

Kicking the build again

@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

This is strange since I integrated pharo-project/pharo#16319

@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

May be pharo-project/pharo#16319 is not available yet?

@adri09070
Copy link
Contributor Author

adri09070 commented Jun 13, 2024

Yes, I don't think pharo-project/pharo#16319 is available yet.
Moreover, the other PR has been merged into Pharo13 and this PR targets Pharo12.
Both PRs should be merged into Pharo13 and Pharo12.

You can change the target branch of this PR to Pharo13 (I have the rights to do it, but I don't find the button to do it on Github) and if the test passes, you could later merge both PRs into Pharo12

@adri09070 adri09070 changed the base branch from Pharo12 to Pharo13 June 13, 2024 08:04
@adri09070
Copy link
Contributor Author

Ah, I found the button

@adri09070
Copy link
Contributor Author

But we still need pharo-project/pharo#16319 to be available. I don't know when new Pharo builds are built

@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

Let us wait a bit and see.

@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

I do not understand because the test is failing

StDebuggerActionModelTest
 ✗ #testRecompileMethodToInBlockContextWithDeadHomeTwice (5ms)

@Ducasse Ducasse added the need more work This needs to be improved before being considered label Jun 13, 2024
@adri09070 adri09070 closed this Jun 14, 2024
@adri09070 adri09070 reopened this Jun 14, 2024
@adri09070 adri09070 removed the need more work This needs to be improved before being considered label Jun 14, 2024
@adri09070
Copy link
Contributor Author

adri09070 commented Jun 14, 2024

We just had to wait for the next Pharo build. The NewTools CI does not create a full image with the bootstrap.

Failing test is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport! bug Something isn't working debugger

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Debugger][P12] Recompiling code within a bloc cannot be done more than once in the debugger

2 participants