Remove StackInterpreter interruptPending instance variable#793
Merged
Remove StackInterpreter interruptPending instance variable#793
Conversation
365f612 to
5f871b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instance variable
interruptPendingfrom theStackInterpreterclass is only used in this method and it's never initialized (see the file changed from this PR). When this code gets compiled to C we get the following.The variable get declared like this
sqInt interruptPending;but it's never initialized. So, the conditionalif (GIV(interruptPending))will never be true as the variable was never initialized.As the
interruptPendingvariable is only used in that method and never initialized, I propose to delete that code snipped as it's never reached and it will never be true.