Remove (wrong) primitive usage#16780
Merged
demarey merged 1 commit intopharo-project:Pharo13from Jun 17, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16775
Fix hpi-swa/smalltalkCI#646 (comment)
Primitive 231 was never implemented on the VM, or at least not since a Loooong time.
See https://github.com/pharo-project/pharo-vm/compare/v10.0.5...v10.2.1
And recently it got defined to provide an object's format:
(231 primitiveFormat)However, it is used in the Random class, probably a leftover of some prototype.
I'll propose a PR, just removing the primitive tag in primitiveRandomNumber: should be enough to get back the old behavior. We should also back port it to P12.