Propose a DarkBlueTheme#16777
Merged
Ducasse merged 3 commits intopharo-project:Pharo13from Jun 19, 2024
Merged
Conversation
As discussed during the Pharo 13 planning meeting, I am proposing a new theme for Pharo 13: DarkBlueTheme
Member
|
Nice looking! Some of the broken tests look related. 
|
Member
Author
|
I'm sure they are the tests relying on the current style and not on a mock :/ I'll check that |
Member
Yes, probably making those tests less fragile is a good move |
Member
Author
|
I already rewrote a lot of those tests in P12 to not compare the style applied but to compare the name of the applied style. I'll check if I can use that also for those 4 tests because I don't want to have to update them at each theme change |
I removed tests that tested the styling of Shout comparing with hardcoded styles. For some test I implemented equivalent ones in SHRBStyleAttributionTest and some others already had an equivalent in SHRBStyleAttributionTest
Member
Author
|
I don't know if the failing AST tests are related. I'll try to check |
Member
Author
|
The remaining failing tests are not related! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed during the Pharo 13 planning meeting, I am proposing a new theme for Pharo 13: DarkBlueTheme
Here is a preview: