Backport use of FormSet for #withCloseBox and #withPinBox on MenuTitleMorph#16774
Merged
jecisc merged 8 commits intopharo-project:Pharo12from Jun 18, 2024
Merged
Conversation
…g:withFormSet:helpText: on MenuTitleMorph.
…leMorph into #pinForm so that it also applies to #updatePinForm.
…or to the creation of the morph.
Member
|
I merged P12 branch to restart the CI now that fixes happened |
Contributor
Author
|
OK thanks! You could also just close and reopen the pull request to start a new build I think, the builds also perform a merge, the log for build 2 of this pull request shows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request backports the changes of pull request #16696 to Pharo 12 (the branch is the same, I started it from the last common ancestor of the ‘Pharo13’ and ‘Pharo12’ branches to allow for that).