Custom scopes can be browsed in Calypso#16771
Conversation
| { #category : 'accessing' } | ||
| { #category : 'comparing' } | ||
| ClyScopedSystemEnvironment >> identityHash [ | ||
| ^ self scope label identityHash |
There was a problem hiding this comment.
@tesonep I implemented this to be able to use these system environments as keys in the dictionary defaultGlobalEnvironments. It doesn't smell good, but I couldn't think of another way, could you please give me your feedback on it?
There was a problem hiding this comment.
It is strange that the GlobalEnvironment is an identityDictionary.
I will put a comment and mark it as something we need to fix
tesonep
left a comment
There was a problem hiding this comment.
Can you add a comment in the smelly method
|
Hi @carolahp this is breaking the latest build in a way that it's difficult to work. I'm going to propose a revert, do not hesitate to redo the PR with a new enhanced version! |
|
Hello @guillep, I understand, I will take a look now and redo the PR |
|
Thanks @carolahp ! |
Currently, custom scopes, these are scopes created by users through the scopes editor, cannot be correctly browsed on Calypso.
This PR correctly enables the previous feature.
However, creating/editing/removing classes, methods, etc in the scope has not been tested, and remains as work to be done.
This work depends on NewTools PR#783