Rename RBNode into ASTNode#16596
Merged
Ducasse merged 3 commits intopharo-project:Pharo13from Jun 19, 2024
Merged
Conversation
Member
|
Hi @jecisc could this be made backwards compatible? Why not a deprecation? |
Member
Author
|
I added a deprecated alias in the poast load of BaselineOfIDE. I cannot use the initialize method since this code is not loaded by Monticello |
Member
Author
|
Failures seems unrelated now |
Member
|
Cyril this is important that we do not remove this names in P14. |
Member
Author
|
It rewrites extension methods holders but not references. Marcus would like to add that in Pharo 13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename RBNode into ASTNode.
I could try to do all AST classes at once but I tried multiple time in the past and it failed and the PR was huge so I'm doing the first easy step here.