Support basic usage of class_alias (With review comments addressed) #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports the most basic form of class_alias, which probably covers most use cases. It adds aliases for class_alias used in the global scope with constant string arguments or the class referenced via the ::class constant. Fixes phan#521
This PR is based off of phan#586 - Account for daemon mode (Not fully tested with the config setting on yet) - Parse class_alias original and alias FQSENs in one phase, and create the entries in another phase (Keeps the number of times each file is parsed the same as before) - Follow variable naming conventions - Tests continue to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #761 , which had merge conflicts and needed to address some review comments.
#761 was refactored/rewritten based on my review comments. The following changes were added:
'enable_class_alias_support' => truein a project's .phan/config.php in order to use this.(Not fully tested with the config setting on yet)
and create the entries in another phase
(Keeps the number of times each file is parsed the same as before)