Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
glensc
reviewed
Jun 5, 2026
glensc
reviewed
Jun 5, 2026
glensc
reviewed
Jun 5, 2026
glensc
reviewed
Jun 5, 2026
glensc
reviewed
Jun 10, 2026
| && echo "extension=phalcon.so" > /usr/local/etc/php/conf.d/70-phalcon.ini \ | ||
| # Cleanup \ | ||
| && apt-get autoremove --purge -y curl \ | ||
| && rm -rf /tmp/* /var/tmp/* /srv |
Contributor
There was a problem hiding this comment.
This remains odd. It's not installed in current dockerfile (resources/docker/develop/Dockerfile), but still purged:
apt-get autoremove --purge -y curl
also, this cleanup shouldn't happen, nothing fills it in prod layer, such cleanup already exists in base layer:
rm -rf /tmp/* /var/tmp/* /srv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Reorganization of quality tool config files (in
resources/)Moved docker in
resources/Refactored docker images (more flexible less cruft)
Moved CI tools in
resources/removed unused onesFixed warning in
Auth/ManagerFactoryemitted in tests (random commit but had to be fixed)Removed unused
Lifetime